Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Math without margin applying value responsibility #313

Merged
merged 5 commits into from
Sep 24, 2023
Merged

Conversation

johnfercher
Copy link
Owner

@johnfercher johnfercher commented Sep 24, 2023

Description

  • Remove responsibility of math applying margins
  • Move margins applying responsibility to bar, qr, matrix and image.
  • Start unit tests of math

Related Issue

Checklist

check with "x", if applied to your change

  • All methods associated with structs has func (s *struct) method() {} name style.
  • Wrote unit tests for new/changed features.
  • Updated docs/doc.go
  • Updated pkg/pdf/example_test.go
  • Updated README.md
  • Updated all examples inside internal/examples
  • New public methods/structs/interfaces has comments upside them explaining they responsibilities
  • Executed make dod with none issues pointed out by golangci-lint and goreportcard-cli

@codecov
Copy link

codecov bot commented Sep 24, 2023

Codecov Report

Patch coverage: 38.99% and project coverage change: +2.61% 🎉

Comparison is base (d38470c) 23.56% compared to head (4a6d56c) 26.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2     #313      +/-   ##
==========================================
+ Coverage   23.56%   26.16%   +2.61%     
==========================================
  Files          20       20              
  Lines         968      971       +3     
==========================================
+ Hits          228      254      +26     
+ Misses        734      710      -24     
- Partials        6        7       +1     
Flag Coverage Δ
unittests 26.16% <38.99%> (+2.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
internal/code.go 0.00% <0.00%> (ø)
internal/image.go 0.00% <0.00%> (ø)
internal/math/math.go 53.85% <51.12%> (+49.93%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnfercher johnfercher marked this pull request as ready for review September 24, 2023 21:10
@johnfercher johnfercher merged commit fe92d09 into v2 Sep 24, 2023
@johnfercher johnfercher deleted the v2-math-srp branch September 24, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant