Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert PDF to ZPL, Fix text side-effect update on cell #315

Merged
merged 8 commits into from
Sep 27, 2023
Merged

Conversation

johnfercher
Copy link
Owner

@johnfercher johnfercher commented Sep 27, 2023

Description

  • Convert PDF to ZPL
  • Fix text side-effect update on cell

Related Issue

Checklist

check with "x", if applied to your change

  • All methods associated with structs has func (s *struct) method() {} name style.
  • Wrote unit tests for new/changed features.
  • Updated docs/doc.go
  • Updated pkg/pdf/example_test.go
  • Updated README.md
  • Updated all examples inside internal/examples
  • New public methods/structs/interfaces has comments upside them explaining they responsibilities
  • Executed make dod with none issues pointed out by golangci-lint and goreportcard-cli

@johnfercher johnfercher changed the base branch from master to v2 September 27, 2023 04:17
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v2@c2a8ed2). Click here to learn what that means.

Additional details and impacted files
@@          Coverage Diff          @@
##             v2     #315   +/-   ##
=====================================
  Coverage      ?   26.00%           
=====================================
  Files         ?       20           
  Lines         ?      958           
  Branches      ?        0           
=====================================
  Hits          ?      249           
  Misses        ?      703           
  Partials      ?        6           
Flag Coverage Δ
unittests 26.00% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnfercher johnfercher marked this pull request as ready for review September 27, 2023 21:22
@johnfercher johnfercher changed the title V2 zpl2 Convert PDF to ZPL, Fix text side-effect update on cell Sep 27, 2023
@johnfercher johnfercher merged commit 28988e5 into v2 Sep 27, 2023
@johnfercher johnfercher deleted the v2-zpl2 branch September 27, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant