Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add background #324

Merged
merged 2 commits into from
Oct 1, 2023
Merged

Add background #324

merged 2 commits into from
Oct 1, 2023

Conversation

johnfercher
Copy link
Owner

@johnfercher johnfercher commented Oct 1, 2023

Description

Related Issue

close #154

Checklist

check with "x", if applied to your change

  • All methods associated with structs has func (s *struct) method() {} name style.
  • Wrote unit tests for new/changed features.
  • Updated docs/doc.go
  • Updated pkg/pdf/example_test.go
  • Updated README.md
  • Updated all examples inside internal/examples
  • New public methods/structs/interfaces has comments upside them explaining they responsibilities
  • Executed make dod with none issues pointed out by golangci-lint and goreportcard-cli

@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (b5c4d0d) 31.69% compared to head (ccddd37) 31.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2     #324      +/-   ##
==========================================
- Coverage   31.69%   31.60%   -0.09%     
==========================================
  Files          20       19       -1     
  Lines         931      937       +6     
==========================================
+ Hits          295      296       +1     
- Misses        629      634       +5     
  Partials        7        7              
Flag Coverage Δ
unittests 31.60% <50.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/code/code.go 87.50% <100.00%> (ø)
internal/math/math.go 100.00% <100.00%> (ø)
pkg/maroto.go 10.99% <100.00%> (ø)
pkg/repository/repository.go 90.91% <100.00%> (ø)
internal/signature.go 0.00% <0.00%> (ø)
internal/text.go 0.00% <0.00%> (ø)
pkg/components/col/col.go 31.25% <50.00%> (ø)
internal/line.go 0.00% <0.00%> (ø)
internal/image.go 0.00% <0.00%> (ø)
pkg/config/builder.go 56.10% <46.43%> (-2.99%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnfercher johnfercher merged commit f6b78da into v2 Oct 1, 2023
@johnfercher johnfercher deleted the v2-background-image branch October 1, 2023 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant