Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test image, line and pdf document #334

Merged
merged 10 commits into from
Oct 7, 2023
Merged

Unit test image, line and pdf document #334

merged 10 commits into from
Oct 7, 2023

Conversation

johnfercher
Copy link
Owner

@johnfercher johnfercher commented Oct 7, 2023

Description

  • Fix cov and linter files to only work in real code;
  • Update unittests example with line;
  • Add more fixtures;
  • Unit test image package: bytesImage, fileImage and fromBytes;
  • Unit test line package;
  • Rename orientation string type;
  • Improve saving of pdf;
  • Unit test pdf document;
  • GoDoc on line props;
  • Unittest the test package;
  • Add more test/maroto jsons.

Related Issue

Checklist

check with "x", if applied to your change

  • All methods associated with structs has func (s *struct) method() {} name style.
  • Wrote unit tests for new/changed features.
  • Updated docs/doc.go
  • Updated pkg/pdf/example_test.go
  • Updated README.md
  • Updated all examples inside internal/examples
  • New public methods/structs/interfaces has comments upside them explaining they responsibilities
  • Executed make dod with none issues pointed out by golangci-lint and goreportcard-cli

@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v2@62f4191). Click here to learn what that means.

Additional details and impacted files
@@          Coverage Diff          @@
##             v2     #334   +/-   ##
=====================================
  Coverage      ?   44.11%           
=====================================
  Files         ?       42           
  Lines         ?     1451           
  Branches      ?        0           
=====================================
  Hits          ?      640           
  Misses        ?      792           
  Partials      ?       19           
Flag Coverage Δ
unittests 44.11% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnfercher johnfercher changed the title Add more tests Unit test image, line and pdf document Oct 7, 2023
@johnfercher johnfercher merged commit 81d412d into v2 Oct 7, 2023
@johnfercher johnfercher deleted the v2-unit-tests2 branch October 7, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant