Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fonts repository + builder #340

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Improve fonts repository + builder #340

merged 2 commits into from
Oct 10, 2023

Conversation

johnfercher
Copy link
Owner

Description

  • Improve fonts repository + builder

Related Issue

Checklist

check with "x", if applied to your change

  • All methods associated with structs has func (s *struct) method() {} name style.
  • Wrote unit tests for new/changed features.
  • Updated docs/doc.go
  • Updated pkg/pdf/example_test.go
  • Updated README.md
  • Updated all examples inside internal/examples
  • New public methods/structs/interfaces has comments upside them explaining they responsibilities
  • Executed make dod with none issues pointed out by golangci-lint and goreportcard-cli

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (04109aa) 43.29% compared to head (46301a3) 43.37%.

❗ Current head 46301a3 differs from pull request most recent head ccf1e0f. Consider uploading reports for the commit ccf1e0f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##               v2     #340      +/-   ##
==========================================
+ Coverage   43.29%   43.37%   +0.09%     
==========================================
  Files          42       42              
  Lines        1541     1538       -3     
==========================================
  Hits          667      667              
+ Misses        857      854       -3     
  Partials       17       17              
Flag Coverage Δ
unittests 43.37% <0.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/config/builder.go 57.15% <0.00%> (+1.05%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnfercher johnfercher merged commit f907ea7 into v2 Oct 10, 2023
@johnfercher johnfercher deleted the v2-refactor-repository branch October 10, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant