Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics tests #354

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Add metrics tests #354

merged 1 commit into from
Oct 24, 2023

Conversation

johnfercher
Copy link
Owner

Description

Related Issue

  • Add metrics tests

Checklist

check with "x", if applied to your change

  • All methods associated with structs has func (s *struct) method() {} name style.
  • Wrote unit tests for new/changed features.
  • Updated docs/doc.go
  • Updated pkg/pdf/example_test.go
  • Updated README.md
  • Updated all examples inside internal/examples
  • New public methods/structs/interfaces has comments upside them explaining they responsibilities
  • Executed make dod with none issues pointed out by golangci-lint and goreportcard-cli

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v2@6197ee3). Click here to learn what that means.

Additional details and impacted files
@@          Coverage Diff          @@
##             v2     #354   +/-   ##
=====================================
  Coverage      ?   71.24%           
=====================================
  Files         ?       61           
  Lines         ?     1999           
  Branches      ?        0           
=====================================
  Hits          ?     1424           
  Misses        ?      551           
  Partials      ?       24           
Flag Coverage Δ
unittests 71.24% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnfercher johnfercher merged commit 515a2c1 into v2 Oct 24, 2023
@johnfercher johnfercher deleted the v2-unit-tests-metrics branch October 24, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant