Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/docs: fix go get install command in docs #356

Merged
merged 1 commit into from
Oct 26, 2023
Merged

fix/docs: fix go get install command in docs #356

merged 1 commit into from
Oct 26, 2023

Conversation

aleicher
Copy link
Contributor

Description
fixes #355

Related Issue
#355

Checklist

check with "x", if applied to your change

  • All methods associated with structs has func (s *struct) method() {} name style.
  • Wrote unit tests for new/changed features.
  • Updated docs/doc.go
  • Updated pkg/pdf/example_test.go
  • Updated README.md
  • Updated all examples inside internal/examples
  • New public methods/structs/interfaces has comments upside them explaining they responsibilities
  • Executed make dod with none issues pointed out by golangci-lint and goreportcard-cli

@aleicher
Fix Readme.md go get url for maroto v2
e85e3c9 
due to refactoring in johnfercher@04ce38b the go get github.com/johnfercher/maroto/v2/pkg@v2.0.0-alpha.41 no longer has an install candidate, the proper install command would now be go get github.com/johnfercher/maroto/v2@v2.0.0-alpha.41
@aleicher aleicher changed the base branch from master to v2 October 26, 2023 15:14
@johnfercher
Copy link
Owner

Thx!

@johnfercher johnfercher merged commit c29ce84 into johnfercher:v2 Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

go get url for maroto v2 in docs broken
2 participants
@aleicher @johnfercher