Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc #359

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Update doc #359

merged 2 commits into from
Oct 27, 2023

Conversation

johnfercher
Copy link
Owner

Description

  • Update doc

Related Issue

Checklist

check with "x", if applied to your change

  • All methods associated with structs has func (<first letter of struct> *struct) method() {} name style.
  • Wrote unit tests for new/changed features.
  • Followed the unit test when,should naming pattern.
  • Updated docs/doc.go and docs/*
  • Updated pkg/pdf/example_test.go
  • Updated README.md
  • Executed make v2 to update all examples inside docs/examples.
  • New public methods/structs/interfaces has comments upside them explaining they responsibilities
  • Executed make dod with none issues pointed out by golangci-lint

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (093992d) 78.43% compared to head (95b56df) 78.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #359   +/-   ##
=======================================
  Coverage   78.43%   78.43%           
=======================================
  Files          61       61           
  Lines        2007     2007           
=======================================
  Hits         1574     1574           
  Misses        404      404           
  Partials       29       29           
Flag Coverage Δ
unittests 78.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnfercher johnfercher merged commit 8479b30 into master Oct 27, 2023
@johnfercher johnfercher deleted the v2-beta-bersion branch October 27, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant