Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log fatal #362

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Fix log fatal #362

merged 1 commit into from
Nov 1, 2023

Conversation

johnfercher
Copy link
Owner

@johnfercher johnfercher commented Nov 1, 2023

Description

  • Fix log fatal

Related Issue

related to #360

Checklist

check with "x", if applied to your change

  • All methods associated with structs has func (<first letter of struct> *struct) method() {} name style.
  • Wrote unit tests for new/changed features.
  • Followed the unit test when,should naming pattern.
  • Updated docs/doc.go and docs/*
  • Updated pkg/pdf/example_test.go
  • Updated README.md
  • Executed make examples to update all examples inside docs/examples.
  • New public methods/structs/interfaces has comments upside them explaining they responsibilities
  • Executed make dod with none issues pointed out by golangci-lint

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6db89e8) 78.43% compared to head (eb38e68) 78.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #362   +/-   ##
=======================================
  Coverage   78.43%   78.43%           
=======================================
  Files          61       61           
  Lines        2007     2007           
=======================================
  Hits         1574     1574           
  Misses        404      404           
  Partials       29       29           
Flag Coverage Δ
unittests 78.43% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
maroto.go 79.36% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnfercher johnfercher merged commit d0198a0 into master Nov 1, 2023
4 of 5 checks passed
@johnfercher johnfercher deleted the fix-log-fatal branch November 1, 2023 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant