Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features: Add hyperlink to text props #372

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

Tantatorn-dev
Copy link
Contributor

Description
I've add hyperlink to text props. It will create a box of link covered the text using gofpdf's LinkString

Related Issue
#191

Checklist

check with "x", if applied to your change

  • [x ] All methods associated with structs has func (<first letter of struct> *struct) method() {} name style.
  • Wrote unit tests for new/changed features.
  • Followed the unit test when,should naming pattern.
  • Updated docs/doc.go and docs/*
  • Updated pkg/pdf/example_test.go
  • Updated README.md
  • Executed make examples to update all examples inside docs/examples.
  • New public methods/structs/interfaces has comments upside them explaining they responsibilities
  • Executed make dod with none issues pointed out by golangci-lint

@Tantatorn-dev Tantatorn-dev changed the title Add hyperlink to text props Features: Add hyperlink to text props Nov 24, 2023
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (91daec6) 80.32% compared to head (9a271ab) 79.99%.

Files Patch % Lines
internal/providers/gofpdf/text.go 0.00% 7 Missing ⚠️
pkg/props/text.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #372      +/-   ##
==========================================
- Coverage   80.32%   79.99%   -0.33%     
==========================================
  Files          61       61              
  Lines        2007     2008       +1     
==========================================
- Hits         1612     1606       -6     
- Misses        367      376       +9     
+ Partials       28       26       -2     
Flag Coverage Δ
unittests 79.99% <0.00%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnfercher
Copy link
Owner

Thanks for the implementation 🚀

@johnfercher johnfercher merged commit 995e31f into johnfercher:master Nov 27, 2023
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants