Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add page tests #391

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Add page tests #391

merged 2 commits into from
Jan 18, 2024

Conversation

johnfercher
Copy link
Owner

@johnfercher johnfercher commented Jan 18, 2024

Description

  • Add page unit tests

Related Issue

Checklist

check with "x", if applied to your change

  • All methods associated with structs has func (<first letter of struct> *struct) method() {} name style.
  • Wrote unit tests for new/changed features.
  • Followed the unit test when,should naming pattern.
  • Updated docs/doc.go and docs/*
  • Updated pkg/pdf/example_test.go
  • Updated README.md
  • Executed make examples to update all examples inside docs/examples.
  • New public methods/structs/interfaces has comments upside them explaining they responsibilities
  • Executed make dod with none issues pointed out by golangci-lint

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (21b2202) 79.84% compared to head (054319e) 81.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #391      +/-   ##
==========================================
+ Coverage   79.84%   81.57%   +1.74%     
==========================================
  Files          61       61              
  Lines        2018     2018              
==========================================
+ Hits         1611     1646      +35     
+ Misses        379      345      -34     
+ Partials       28       27       -1     
Flag Coverage Δ
unittests 81.57% <ø> (+1.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnfercher johnfercher merged commit cce8565 into master Jan 18, 2024
5 checks passed
@johnfercher johnfercher deleted the improve-unit-tests branch January 18, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant