Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs #393

Merged
merged 5 commits into from
Jan 30, 2024
Merged

Update docs #393

merged 5 commits into from
Jan 30, 2024

Conversation

johnfercher
Copy link
Owner

@johnfercher johnfercher commented Jan 30, 2024

Description

  • Update docs

Related Issue

#386

Checklist

check with "x", if applied to your change

  • All methods associated with structs has func (<first letter of struct> *struct) method() {} name style.
  • Wrote unit tests for new/changed features.
  • Followed the unit test when,should naming pattern.
  • Updated docs/doc.go and docs/*
  • Updated pkg/pdf/example_test.go
  • Updated README.md
  • Executed make examples to update all examples inside docs/examples.
  • New public methods/structs/interfaces has comments upside them explaining they responsibilities
  • Executed make dod with none issues pointed out by golangci-lint

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (319c593) 81.57% compared to head (dd54025) 81.57%.

Files Patch % Lines
maroto.go 82.36% 3 Missing ⚠️
metricsdecorator.go 80.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #393   +/-   ##
=======================================
  Coverage   81.57%   81.57%           
=======================================
  Files          61       61           
  Lines        2018     2018           
=======================================
  Hits         1646     1646           
  Misses        345      345           
  Partials       27       27           
Flag Coverage Δ
unittests 81.57% <81.49%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnfercher johnfercher merged commit f96a873 into master Jan 30, 2024
4 of 5 checks passed
@johnfercher johnfercher deleted the doc/improve-site branch January 30, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant