Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/new-barcodes #401

Merged
merged 3 commits into from
Feb 21, 2024
Merged

feature/new-barcodes #401

merged 3 commits into from
Feb 21, 2024

Conversation

johnfercher
Copy link
Owner

@johnfercher johnfercher commented Feb 21, 2024

Description

#399

Related Issue

Checklist

check with "x", if applied to your change

  • All methods associated with structs has func (<first letter of struct> *struct) method() {} name style.
  • Wrote unit tests for new/changed features.
  • Followed the unit test when,should naming pattern.
  • Updated docs/doc.go and docs/*
  • Updated pkg/pdf/example_test.go
  • Updated README.md
  • Executed make examples to update all examples inside docs/examples.
  • New public methods/structs/interfaces has comments upside them explaining they responsibilities
  • Executed make dod with none issues pointed out by golangci-lint

@johnfercher johnfercher changed the title Add EAN feature/new-barcodes Feb 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b7837eb) 81.64% compared to head (390ad07) 81.66%.

Files Patch % Lines
internal/providers/gofpdf/provider.go 66.67% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #401      +/-   ##
==========================================
+ Coverage   81.64%   81.66%   +0.02%     
==========================================
  Files          61       61              
  Lines        2026     2039      +13     
==========================================
+ Hits         1654     1665      +11     
- Misses        345      346       +1     
- Partials       27       28       +1     
Flag Coverage Δ
unittests 81.66% <88.89%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnfercher johnfercher merged commit 0696624 into master Feb 21, 2024
7 checks passed
@johnfercher johnfercher deleted the feature/new-barcodes branch February 21, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant