Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

features/add method to return pdf settings #440

Merged
merged 3 commits into from
May 26, 2024

Conversation

Fernando-hub527
Copy link
Collaborator

Description
Add method to core.maroto to return current pdf settings

Related Issue
#438

Checklist

check with "x", ONLY IF APPLIED to your change

  • All methods associated with structs has func (<first letter of struct> *struct) method() {} name style.
  • Wrote unit tests for new/changed features.
  • Followed the unit test when,should naming pattern.
  • All mocks created with m := mocks.NewConstructor(t).
  • All mocks using m.EXPECT().MethodName() method to mock methods.
  • Updated docs/doc.go and docs/*
  • Updated example_test.go.
  • Updated README.md
  • Executed make examples to update all examples inside docs/examples.
  • New public methods/structs/interfaces has comments upside them explaining they responsibilities
  • Executed make dod with none issues pointed out by golangci-lint

Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 84.06%. Comparing base (cb26f0d) to head (6fc9743).

Files Patch % Lines
metricsdecorator.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #440      +/-   ##
==========================================
- Coverage   84.13%   84.06%   -0.06%     
==========================================
  Files          61       61              
  Lines        2110     2114       +4     
==========================================
+ Hits         1775     1777       +2     
- Misses        308      310       +2     
  Partials       27       27              
Flag Coverage Δ
unittests 84.06% <50.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnfercher johnfercher merged commit f76ae41 into johnfercher:master May 26, 2024
3 of 5 checks passed
@lordofscripts
Copy link

Is there anywhere a description how this affects applications without having to examine the commits?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants