Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code bug and add documentation #467

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Fix code bug and add documentation #467

merged 1 commit into from
Aug 2, 2024

Conversation

johnfercher
Copy link
Owner

@johnfercher johnfercher commented Aug 2, 2024

Description

  • Fix code bug and add documentation

Related Issue

Checklist

check with "x", ONLY IF APPLIED to your change

  • All methods associated with structs has func (<first letter of struct> *struct) method() {} name style.
  • Wrote unit tests for new/changed features.
  • Followed the unit test when,should naming pattern.
  • All mocks created with m := mocks.NewConstructor(t).
  • All mocks using m.EXPECT().MethodName() method to mock methods.
  • Updated docs/doc.go and docs/*
  • Updated example_test.go.
  • Updated README.md
  • New public methods/structs/interfaces has comments upside them explaining they responsibilities
  • Executed make dod with none issues pointed out by golangci-lint

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.04%. Comparing base (35d40c9) to head (d5c3ba0).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #467   +/-   ##
=======================================
  Coverage   87.04%   87.04%           
=======================================
  Files          61       61           
  Lines        2321     2321           
=======================================
  Hits         2020     2020           
  Misses        269      269           
  Partials       32       32           
Flag Coverage Δ
unittests 87.04% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnfercher johnfercher merged commit 8a057a1 into master Aug 2, 2024
5 checks passed
@johnfercher johnfercher deleted the docs/autorow branch August 2, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant