Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/metadata not set #486

Merged
merged 1 commit into from
Oct 15, 2024
Merged

fix/metadata not set #486

merged 1 commit into from
Oct 15, 2024

Conversation

Fernando-hub527
Copy link
Collaborator

Description
fix bug in metadata configuration

Related Issue
#485

Checklist

check with "x", ONLY IF APPLIED to your change

  • All methods associated with structs has func (<first letter of struct> *struct) method() {} name style.
  • Wrote unit tests for new/changed features.
  • Followed the unit test when,should naming pattern.
  • All mocks created with m := mocks.NewConstructor(t).
  • All mocks using m.EXPECT().MethodName() method to mock methods.
  • Updated docs/doc.go and docs/*
  • Updated example_test.go.
  • Updated README.md
  • New public methods/structs/interfaces has comments upside them explaining they responsibilities
  • Executed make dod with none issues pointed out by golangci-lint

set metadata when the provider is created
@Fernando-hub527 Fernando-hub527 linked an issue Oct 15, 2024 that may be closed by this pull request
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.09%. Comparing base (a325355) to head (cde7411).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #486      +/-   ##
==========================================
+ Coverage   87.09%   87.09%   +0.01%     
==========================================
  Files          61       61              
  Lines        2330     2331       +1     
==========================================
+ Hits         2029     2030       +1     
  Misses        268      268              
  Partials       33       33              
Flag Coverage Δ
unittests 87.09% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fernando-hub527
Copy link
Collaborator Author

Captura de tela de 2024-10-14 23-29-20
The image above demonstrates the resolution of the bug

I would have liked to have implemented tests that validated the changes, but I couldn't think of a way to capture this bug in a test without having to do significant refactoring.
If you consider it important, I can work on this refactoring!!

@johnfercher johnfercher merged commit 688ef1f into master Oct 15, 2024
5 checks passed
@johnfercher johnfercher deleted the fix/metadata-not-set branch October 15, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metadata such as title, author, creator not set
2 participants