The package version must match the major tag version #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to go.mod once you have a version that's > 1.0.0 you must alter the actual package to include the major version number. While you can copy the entire structure into a new folder it's way easier to just adjust
go.modand then update all of the import statements.Without this it's not currently possible to install this with a normal
go installoutside of cloning the entire repo.I ran
make unit-testsand everything seemed to work so hopefully this is everything. I used gomajor for the heavy lifting and rg/xargs/sd for the stragglers.See more
Fixes #1093