Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid assuming ./mlr is the mlr to test #876

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

skitt
Copy link
Contributor

@skitt skitt commented Jan 17, 2022

In test cases, support a ${MLR} placeholder for the mlr binary under
test, instead of assuming it's ./mlr (or its equivalent on platforms
not using forward slashes).

This ensures that wrapped mlr invocations all use the same binary,
either the default or the binary specified by the user, avoiding
surprises when ./mlr doesn't exist or is a different version.

Signed-off-by: Stephen Kitt steve@sk2.org

In test cases, support a ${MLR} placeholder for the mlr binary under
test, instead of assuming it's ./mlr (or its equivalent on platforms
not using forward slashes).

This ensures that wrapped mlr invocations all use the same binary,
either the default or the binary specified by the user, avoiding
surprises when ./mlr doesn't exist or is a different version.

Signed-off-by: Stephen Kitt <steve@sk2.org>
@skitt
Copy link
Contributor Author

skitt commented Jan 17, 2022

This could be used throughout the test cases to avoid the special handling of "mlr " at the beginning of the command, but I wanted to keep this simple for now and provide a straightforward fix for the ./mlr issue.

@johnkerl
Copy link
Owner

Thanks @skitt !!

@johnkerl johnkerl merged commit af7bacf into johnkerl:main Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants