Update jquery.sortable.js Destroy #122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The destroy method doesn't clean itself properly. I dont know if this is the proper way of doing it, but in my code this works. Can you please make a full cleanup so no memory leaks are existing in case of spa ( Single page application )
|
👍 x999 If this PR is no good, there needs to be some way to destroy a group completely because the first call group options persist and may contain callbacks which are destroyed. So the second call uses options with a bunch of dead references. Could this work? |
daftspunk
added a commit
to octobercms/october
that referenced
this pull request
Jul 18, 2015
daftspunk
added a commit
to octobercms/october
that referenced
this pull request
Jul 18, 2015
daftspunk
added a commit
to octoberrain/system
that referenced
this pull request
Jul 19, 2015
daftspunk
added a commit
to octoberrain/system
that referenced
this pull request
Jul 19, 2015
LukeTowers
pushed a commit
to octoberrain/system
that referenced
this pull request
Apr 20, 2019
LukeTowers
pushed a commit
to octoberrain/system
that referenced
this pull request
Apr 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The destroy method doesn't clean itself properly. I dont know if this is the proper way of doing it, but in my code this works. Can you please make a full cleanup so no memory leaks are existing in case of spa ( Single page application )