Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/cleanup #3

Merged
merged 21 commits into from
Jan 4, 2025
Merged

Feature/cleanup #3

merged 21 commits into from
Jan 4, 2025

Conversation

johnnybegood
Copy link
Owner

@johnnybegood johnnybegood commented Jan 2, 2025 •
edited
Loading

Clean-up existing logic:

  • Add unit test
  • Running linting and SonarQube in pipeline
  • Fix all remarks from linting and Sonar
  • Make it more strongly typed
  • Add code comments and docs
  • Add a factory that allows for multiple versions to be used in the future (prepare for 4.0 support)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025 •
edited
Loading

Code Coverage

Package Line Rate Health
ksenia_lares 91% ✔
Summary 91% (170 / 186) ✔

@johnnybegood johnnybegood marked this pull request as ready for review January 4, 2025 15:21
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 4, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
91.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@johnnybegood johnnybegood merged commit 5309104 into main Jan 4, 2025
8 checks passed
@johnnybegood johnnybegood deleted the feature/cleanup branch January 4, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@johnnybegood