perf($Quartz): value constraints for enums

johnnymillergh · Oct 1, 2021 · aeaef0c · aeaef0c
1 parent 9d41106
commit aeaef0c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/...loud-starter/src/main/java/com/jmsoftware/maf/springcloudstarter/quartz/GreetingBean.java b/...loud-starter/src/main/java/com/jmsoftware/maf/springcloudstarter/quartz/GreetingBean.java
@@ -23,6 +23,7 @@ public class GreetingBean {
     private final MafProjectProperty mafProjectProperty;
 
     @QuartzSchedulable
+    @SuppressWarnings("unused")
     public void hello() {
         log.info("Greeting from Quartz job, current service is: {}", this.mafProjectProperty.getProjectArtifactId());
     }

diff --git a/...are/maf/springcloudstarter/quartz/entity/CreateOrModifyQuartzJobConfigurationPayload.java b/...are/maf/springcloudstarter/quartz/entity/CreateOrModifyQuartzJobConfigurationPayload.java
@@ -1,6 +1,10 @@
 package com.jmsoftware.maf.springcloudstarter.quartz.entity;
 
+import com.jmsoftware.maf.springcloudstarter.quartz.constant.Concurrent;
+import com.jmsoftware.maf.springcloudstarter.quartz.constant.MisfirePolicy;
+import com.jmsoftware.maf.springcloudstarter.quartz.constant.QuartzJobStatus;
 import com.jmsoftware.maf.springcloudstarter.quartz.entity.persistence.QuartzJobConfiguration;
+import com.jmsoftware.maf.springcloudstarter.validation.annotation.ValidEnumValue;
 import lombok.Data;
 import lombok.val;
 import org.hibernate.validator.constraints.Length;
@@ -30,13 +34,16 @@ public class CreateOrModifyQuartzJobConfigurationPayload {
     @Length(max = 50)
     private String cronExpression;
     @NotNull
+    @ValidEnumValue(targetEnum = MisfirePolicy.class)
     private Byte misfirePolicy;
     @NotNull
+    @ValidEnumValue(targetEnum = Concurrent.class)
     private Byte concurrent;
     @NotBlank
     @Length(max = 1000)
     private String description;
     @NotNull
+    @ValidEnumValue(targetEnum = QuartzJobStatus.class)
     private Byte status;
 
     public QuartzJobConfiguration asQuartzJobConfiguration() {