Skip to content

Commit

Permalink
perf($ResponseBodyBean): add @nonnull annotation for arguments
Browse files Browse the repository at this point in the history
  • Loading branch information
johnnymillergh committed May 8, 2020
1 parent c9d4c2d commit e85bacf
Show file tree
Hide file tree
Showing 7 changed files with 107 additions and 107 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,14 @@ public class CommonController {
@ApiOperation(value = "/app-info", notes = "Retrieve application information")
public ResponseBodyBean<Map<String, Object>> applicationInformation() {
var data = commonService.getApplicationInfo();
return ResponseBodyBean.ofDataAndMessage(data, "Succeed to retrieve app info.");
return ResponseBodyBean.ofSuccess(data, "Succeed to retrieve app info.");
}

@PostMapping("/validation-test")
@ApiOperation(value = "/validation-test", notes = "Validation of request payload test")
public ResponseBodyBean<String> validationTest(@RequestBody ValidationTestPayload payload) {
commonService.validateObject(payload);
return ResponseBodyBean.ofDataAndMessage(payload.getName(), "validationTest()");
return ResponseBodyBean.ofSuccess(payload.getName(), "validationTest()");
}

@GetMapping("/get-jwt")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,13 @@ public class CommonController {
public ResponseBodyBean<Map<String, Object>> applicationInformation() {
var data = commonService.getApplicationInfo();
redisService.set("appInfo", data.toString());
return ResponseBodyBean.ofDataAndMessage(data, "Succeed to retrieve app info.");
return ResponseBodyBean.ofSuccess(data, "Succeed to retrieve app info.");
}

@PostMapping("/validation-test")
@ApiOperation(value = "/validation-test", notes = "Validation of request payload test")
public ResponseBodyBean<String> validationTest(@RequestBody ValidationTestPayload payload) {
commonService.validateObject(payload);
return ResponseBodyBean.ofDataAndMessage(payload.getName(), "validationTest()");
return ResponseBodyBean.ofSuccess(payload.getName(), "validationTest()");
}
}
190 changes: 95 additions & 95 deletions common/src/main/java/com/jmsoftware/common/bean/ResponseBodyBean.java

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,13 @@ public class CommonController {
@ApiOperation(value = "/app-info", notes = "Retrieve application information")
public ResponseBodyBean<Map<String, Object>> applicationInformation() {
var data = commonService.getApplicationInfo();
return ResponseBodyBean.ofDataAndMessage(data, "Succeed to retrieve app info.");
return ResponseBodyBean.ofSuccess(data, "Succeed to retrieve app info.");
}

@PostMapping("/validation-test")
@ApiOperation(value = "/validation-test", notes = "Validation of request payload test")
public ResponseBodyBean<String> validationTest(@RequestBody ValidationTestPayload payload) {
commonService.validateObject(payload);
return ResponseBodyBean.ofDataAndMessage(payload.getName(), "validationTest()");
return ResponseBodyBean.ofSuccess(payload.getName(), "validationTest()");
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,13 @@ public class CommonController {
@ApiOperation(value = "/app-info", notes = "Retrieve application information")
public ResponseBodyBean<Map<String, Object>> applicationInformation() {
var data = commonService.getApplicationInfo();
return ResponseBodyBean.ofDataAndMessage(data, "Succeed to retrieve app info.");
return ResponseBodyBean.ofSuccess(data, "Succeed to retrieve app info.");
}

@PostMapping("/validation-test")
@ApiOperation(value = "/validation-test", notes = "Validation of request payload test")
public ResponseBodyBean<String> validationTest(@RequestBody ValidationTestPayload payload) {
commonService.validateObject(payload);
return ResponseBodyBean.ofDataAndMessage(payload.getName(), "validationTest()");
return ResponseBodyBean.ofSuccess(payload.getName(), "validationTest()");
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,13 @@ public class CommonController {
@ApiOperation(value = "/app-info", notes = "Retrieve application information")
public ResponseBodyBean<Map<String, Object>> applicationInformation() {
var data = commonService.getApplicationInfo();
return ResponseBodyBean.ofDataAndMessage(data, "Succeed to retrieve app info.");
return ResponseBodyBean.ofSuccess(data, "Succeed to retrieve app info.");
}

@PostMapping("/validation-test")
@ApiOperation(value = "/validation-test", notes = "Validation of request payload test")
public ResponseBodyBean<String> validationTest(@RequestBody ValidationTestPayload payload) {
commonService.validateObject(payload);
return ResponseBodyBean.ofDataAndMessage(payload.getName(), "validationTest()");
return ResponseBodyBean.ofSuccess(payload.getName(), "validationTest()");
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,13 @@ public class CommonController {
@ApiOperation(value = "/app-info", notes = "Retrieve application information")
public ResponseBodyBean<Map<String, Object>> applicationInformation() {
var data = commonService.getApplicationInfo();
return ResponseBodyBean.ofDataAndMessage(data, "Succeed to retrieve app info.");
return ResponseBodyBean.ofSuccess(data, "Succeed to retrieve app info.");
}

@PostMapping("/validation-test")
@ApiOperation(value = "/validation-test", notes = "Validation of request payload test")
public ResponseBodyBean<String> validationTest(@RequestBody ValidationTestPayload payload) {
commonService.validateObject(payload);
return ResponseBodyBean.ofDataAndMessage(payload.getName(), "validationTest()");
return ResponseBodyBean.ofSuccess(payload.getName(), "validationTest()");
}
}

0 comments on commit e85bacf

Please sign in to comment.