perf($Exception): simplify trace and message of response

johnnymillergh · May 12, 2020 · eae6793 · eae6793
1 parent e053296
commit eae6793
Show file tree

Hide file tree

Showing 6 changed files with 54 additions and 0 deletions.
diff --git a/api-portal/src/main/java/com/jmsoftware/apiportal/universal/controller/ErrorController.java b/api-portal/src/main/java/com/jmsoftware/apiportal/universal/controller/ErrorController.java
@@ -14,6 +14,7 @@
 import javax.servlet.http.HttpServletRequest;
 import java.util.List;
 import java.util.Map;
+import java.util.Optional;
 
 /**
  * <h1>ErrorController</h1>
@@ -38,6 +39,14 @@ public ResponseEntity<Map<String, Object>> error(HttpServletRequest request) {
         val httpStatus = getStatus(request);
         val body = getErrorAttributes(request, isIncludeStackTrace(request, MediaType.ALL));
         body.put("message", httpStatus.getReasonPhrase());
+        val optionalTrace = Optional.ofNullable(body.get("trace"));
+        optionalTrace.ifPresent(trace -> {
+            val message = body.get("message");
+            val firstLineOfTrace = trace.toString().split("\\n")[0];
+            val joinedMessage = String.format("%s %s", message, firstLineOfTrace);
+            body.put("message", joinedMessage);
+            body.put("trace", "Trace has been simplified. Refer to 'message'");
+        });
         log.error("Captured HTTP request error. Response body = {}", body);
         return new ResponseEntity<>(body, httpStatus);
     }

diff --git a/...-center/src/main/java/com/jmsoftware/authcenter/universal/controller/ErrorController.java b/...-center/src/main/java/com/jmsoftware/authcenter/universal/controller/ErrorController.java
@@ -14,6 +14,7 @@
 import javax.servlet.http.HttpServletRequest;
 import java.util.List;
 import java.util.Map;
+import java.util.Optional;
 
 /**
  * <h1>ErrorController</h1>
@@ -38,6 +39,14 @@ public ResponseEntity<Map<String, Object>> error(HttpServletRequest request) {
         val httpStatus = getStatus(request);
         val body = getErrorAttributes(request, isIncludeStackTrace(request, MediaType.ALL));
         body.put("message", httpStatus.getReasonPhrase());
+        val optionalTrace = Optional.ofNullable(body.get("trace"));
+        optionalTrace.ifPresent(trace -> {
+            val message = body.get("message");
+            val firstLineOfTrace = trace.toString().split("\\n")[0];
+            val joinedMessage = String.format("%s %s", message, firstLineOfTrace);
+            body.put("message", joinedMessage);
+            body.put("trace", "Trace has been simplified. Refer to 'message'");
+        });
         log.error("Captured HTTP request error. Response body = {}", body);
         return new ResponseEntity<>(body, httpStatus);
     }

diff --git a/...se-mis/src/main/java/com/jmsoftware/exercisemis/universal/controller/ErrorController.java b/...se-mis/src/main/java/com/jmsoftware/exercisemis/universal/controller/ErrorController.java
@@ -14,6 +14,7 @@
 import javax.servlet.http.HttpServletRequest;
 import java.util.List;
 import java.util.Map;
+import java.util.Optional;
 
 /**
  * <h1>ErrorController</h1>
@@ -38,6 +39,14 @@ public ResponseEntity<Map<String, Object>> error(HttpServletRequest request) {
         val httpStatus = getStatus(request);
         val body = getErrorAttributes(request, isIncludeStackTrace(request, MediaType.ALL));
         body.put("message", httpStatus.getReasonPhrase());
+        val optionalTrace = Optional.ofNullable(body.get("trace"));
+        optionalTrace.ifPresent(trace -> {
+            val message = body.get("message");
+            val firstLineOfTrace = trace.toString().split("\\n")[0];
+            val joinedMessage = String.format("%s %s", message, firstLineOfTrace);
+            body.put("message", joinedMessage);
+            body.put("trace", "Trace has been simplified. Refer to 'message'");
+        });
         log.error("Captured HTTP request error. Response body = {}", body);
         return new ResponseEntity<>(body, httpStatus);
     }

diff --git a/muscle-mis/src/main/java/com/jmsoftware/musclemis/universal/controller/ErrorController.java b/muscle-mis/src/main/java/com/jmsoftware/musclemis/universal/controller/ErrorController.java
@@ -14,6 +14,7 @@
 import javax.servlet.http.HttpServletRequest;
 import java.util.List;
 import java.util.Map;
+import java.util.Optional;
 
 /**
  * <h1>ErrorController</h1>
@@ -38,6 +39,14 @@ public ResponseEntity<Map<String, Object>> error(HttpServletRequest request) {
         val httpStatus = getStatus(request);
         val body = getErrorAttributes(request, isIncludeStackTrace(request, MediaType.ALL));
         body.put("message", httpStatus.getReasonPhrase());
+        val optionalTrace = Optional.ofNullable(body.get("trace"));
+        optionalTrace.ifPresent(trace -> {
+            val message = body.get("message");
+            val firstLineOfTrace = trace.toString().split("\\n")[0];
+            val joinedMessage = String.format("%s %s", message, firstLineOfTrace);
+            body.put("message", joinedMessage);
+            body.put("trace", "Trace has been simplified. Refer to 'message'");
+        });
         log.error("Captured HTTP request error. Response body = {}", body);
         return new ResponseEntity<>(body, httpStatus);
     }

diff --git a/...ry/src/main/java/com/jmsoftware/serviceregistry/universal/controller/ErrorController.java b/...ry/src/main/java/com/jmsoftware/serviceregistry/universal/controller/ErrorController.java
@@ -14,6 +14,7 @@
 import javax.servlet.http.HttpServletRequest;
 import java.util.List;
 import java.util.Map;
+import java.util.Optional;
 
 /**
  * <h1>ErrorController</h1>
@@ -38,6 +39,14 @@ public ResponseEntity<Map<String, Object>> error(HttpServletRequest request) {
         val httpStatus = getStatus(request);
         val body = getErrorAttributes(request, isIncludeStackTrace(request, MediaType.ALL));
         body.put("message", httpStatus.getReasonPhrase());
+        val optionalTrace = Optional.ofNullable(body.get("trace"));
+        optionalTrace.ifPresent(trace -> {
+            val message = body.get("message");
+            val firstLineOfTrace = trace.toString().split("\\n")[0];
+            val joinedMessage = String.format("%s %s", message, firstLineOfTrace);
+            body.put("message", joinedMessage);
+            body.put("trace", "Trace has been simplified. Refer to 'message'");
+        });
         log.error("Captured HTTP request error. Response body = {}", body);
         return new ResponseEntity<>(body, httpStatus);
     }

diff --git a/...in/src/main/java/com/jmsoftware/springbootadmin/universal/controller/ErrorController.java b/...in/src/main/java/com/jmsoftware/springbootadmin/universal/controller/ErrorController.java
@@ -14,6 +14,7 @@
 import javax.servlet.http.HttpServletRequest;
 import java.util.List;
 import java.util.Map;
+import java.util.Optional;
 
 /**
  * <h1>ErrorController</h1>
@@ -38,6 +39,14 @@ public ResponseEntity<Map<String, Object>> error(HttpServletRequest request) {
         val httpStatus = getStatus(request);
         val body = getErrorAttributes(request, isIncludeStackTrace(request, MediaType.ALL));
         body.put("message", httpStatus.getReasonPhrase());
+        val optionalTrace = Optional.ofNullable(body.get("trace"));
+        optionalTrace.ifPresent(trace -> {
+            val message = body.get("message");
+            val firstLineOfTrace = trace.toString().split("\\n")[0];
+            val joinedMessage = String.format("%s %s", message, firstLineOfTrace);
+            body.put("message", joinedMessage);
+            body.put("trace", "Trace has been simplified. Refer to 'message'");
+        });
         log.error("Captured HTTP request error. Response body = {}", body);
         return new ResponseEntity<>(body, httpStatus);
     }