refactor: migrate to NgRx v8 creators #4
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createAction
instead of classes, enums and type unionscreateReducer
over switch statementscreateEffect
Digging through the code I saw some OOP concepts at play with regards to the
HeroAction
andVillainAction
abstract classes. This played nicely into creating a couplehigher order
functions that can be composed. As such, I createdcreate*Action
andcreate*ErrorAction
for both heroes and villains.The one area I did have a hard time in converting was the effects that used the
toAction
helper. Once we release in NgRx themapToAction
operator, this will become a lot easier.Another option would be to create a "higher order" effect like I propose here: ngrx/platform#1826 To standardize the way effects are composed.
Let me know what you think and if you have any questions.