refactor: use NOOP for empty triggers

johnsoncodehk · Oct 26, 2023 · 600966b · 600966b
1 parent b98b6b8
commit 600966b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 11 deletions.
diff --git a/packages/reactivity/src/effect.ts b/packages/reactivity/src/effect.ts
@@ -1,4 +1,4 @@
-import { extend, getGlobalThis } from '@vue/shared'
+import { NOOP, extend, getGlobalThis } from '@vue/shared'
 import type { ComputedRefImpl } from './computed'
 import { DirtyLevels, TrackOpTypes, TriggerOpTypes } from './constants'
 import type { Dep } from './dep'
@@ -237,15 +237,11 @@ export function effect<T = any>(
     fn = (fn as ReactiveEffectRunner).effect.fn
   }
 
-  const _effect = new ReactiveEffect(
-    fn,
-    () => {},
-    () => {
-      if (_effect.dirty) {
-        _effect.run()
-      }
+  const _effect = new ReactiveEffect(fn, NOOP, () => {
+    if (_effect.dirty) {
+      _effect.run()
     }
-  )
+  })
   if (options) {
     extend(_effect, options)
     if (options.scope) recordEffectScope(_effect, options.scope)

diff --git a/packages/runtime-core/src/apiWatch.ts b/packages/runtime-core/src/apiWatch.ts
@@ -361,7 +361,7 @@ function doWatch(
     scheduler = () => queueJob(job)
   }
 
-  const effect = new ReactiveEffect(getter, () => {}, scheduler)
+  const effect = new ReactiveEffect(getter, NOOP, scheduler)
 
   if (__DEV__) {
     effect.onTrack = onTrack

diff --git a/packages/runtime-core/src/renderer.ts b/packages/runtime-core/src/renderer.ts
@@ -1547,7 +1547,7 @@ function baseCreateRenderer(
     // create reactive effect for rendering
     const effect = (instance.effect = new ReactiveEffect(
       componentUpdateFn,
-      () => {},
+      NOOP,
       () => queueJob(update),
       instance.scope // track it in component's effect scope
     ))