Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete Jemalloc #70

Closed
wants to merge 1 commit into from
Closed

Conversation

kornelski
Copy link
Contributor

Rust 1.31 is long dead.

@8573
Copy link

8573 commented Sep 10, 2024

Why delete it entirely, rather than move it to the end, where it will be out of the way of people going down the list for practical use but will still be visible to people who might be interested in what was relevant historically?

@johnthagen
Copy link
Owner

I too have some reservations about deleting it entirely.

I could accept the PR if it was changed to moving it to a new section at the very bottom titled

# Legacy Techniques

## Remove Jemalloc
...

@johnthagen johnthagen self-assigned this Sep 10, 2024
@johnthagen johnthagen added the enhancement New feature or request label Sep 10, 2024
@johnthagen johnthagen self-requested a review September 10, 2024 18:47
Copy link
Owner

@johnthagen johnthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move to a new section at the bottom of the markdown page.

@kornelski
Copy link
Contributor Author

I've thought about it, but couldn't find any reason to keep it, other than loss aversion.

This default is not in Rust any more. Literally nobody uses Rust so old to benefit from this information. It's just an irrelevant distraction, and it became wrong information diluting usefulness of the guide for everyone. It has negative value.

@8573
Copy link

8573 commented Sep 11, 2024

Literally nobody uses Rust so old to benefit from this information.

Not many people now use BSD versions from 30 years ago either, but FreeBSD's source code contains various historical files in case they might be interesting to someone.

It's just an irrelevant distraction, ... It has negative value.

It may be irrelevant and valueless to you, or to people practically shrinking modern Rust executables, but do you have arguments as to why keeping some record of this historical technique would be so bad? You say

it became wrong information diluting usefulness of the guide for everyone

but, if having it at the end is still too much a "distraction", it could be moved to a separate file, linked from the end of the main file.

@johnthagen
Copy link
Owner

johnthagen commented Sep 11, 2024

@kornelski Thank you for bringing this up and providing stats. This has been resolved in

@8573 Thank you for providing your perspective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants