Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use curl for downloads in AppVeyor #115

Merged
merged 2 commits into from
May 15, 2017
Merged

Use curl for downloads in AppVeyor #115

merged 2 commits into from
May 15, 2017

Conversation

johnthagen
Copy link
Owner

@johnthagen johnthagen requested a review from mcdenhoed May 14, 2017 19:47
mcdenhoed
mcdenhoed reviewed May 14, 2017
View reviewed changes
Copy link
Collaborator

@mcdenhoed mcdenhoed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's an unexpected panic when compiling music. I assume this is unrelated to curl?

@mcdenhoed
Copy link
Collaborator

Ah yeah, beta and nightly are broken separately.

@johnthagen
Copy link
Owner Author

Looks like nightly is just rust-fmt I'll fix that. Do you know if the beta breakage is fixed?

@johnthagen
Copy link
Owner Author

Beta regression has already been reported (rust-lang/rust#41944), so we can ignore that one for now.

@johnthagen
Copy link
Owner Author

rustfmt also happens to be broken on Windows: rust-lang/rustfmt#1525

@johnthagen
Copy link
Owner Author

Beta problem has been fixed and is awaiting backport: rust-lang/rust#41604

@johnthagen
Copy link
Owner Author

@mcdenhoed Looks like we're good here other than the known beta regression. I'll merge once you approve changes.

@johnthagen johnthagen merged commit 3c0492d into master May 15, 2017
@johnthagen johnthagen deleted the appveyor-curl2 branch May 15, 2017 16:14
@johnthagen johnthagen mentioned this pull request May 18, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdenhoed mcdenhoed mcdenhoed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnthagen @mcdenhoed