WIndow Orientation #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnwangwyx
reviewed
Oct 17, 2024
There was a problem hiding this comment.
It seems like at least on Windows, calling the getScreenSize() before the creation of add_tag_window will cause the window to be hidden behind by the main window.
Would you mind calling this function at the start of open_add_tag_window()?
Other than that it is great! Thank you for making this change and follow the best practices! It is nice to utilize the utils.py to provide the getScreenSize() function.
Co-authored-by: John Wang <78456315+johnwangwyx@users.noreply.github.com>
Co-authored-by: John Wang <78456315+johnwangwyx@users.noreply.github.com>
|
Thank you!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started by centering the main window+(offset) with the screen. All the side windows will appear justified to the main window. Any other popups will appear in the middle of the screen.
The next step would be to take into account if the main window moves(this current fix does not do so). There are ways in Tkinter to get a window's current position, but we would have to pass the parent window to the child upon creation to call Toplevel..winfo_x() and .winfo_y().