Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for YamlLoader: raise TemplateNotFound instead of returning it #213

Merged
merged 1 commit into from
Feb 28, 2018

Conversation

gregsadetsky
Copy link
Contributor

@gregsadetsky gregsadetsky commented Dec 8, 2017

makes YamlLoader raise, instead of returning, TemplateNotFound

according to the Jinja2 documentation for get_source: [...] has to return a tuple [...] or raise a TemplateNotFound [...]

using return TemplateNotFound (as it's done now) will conflict with other Flask extensions that use templates (for instance, Flask-Admin).

@johnwheeler johnwheeler merged commit 875f509 into johnwheeler:master Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants