Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use io.StringIO in place of StringIO. As per recommendation from Pyth… #220

Merged
merged 1 commit into from
Feb 28, 2018

Conversation

mlsamuelson
Copy link
Contributor

As per recommendation from Python 3.0 changelog (https://docs.python.org/3.0/whatsnew/3.0.html) use io.StringIO in place of StringIO.

io.StringIO is available in both Python 2.7 and 3.6.

Impetus for this change is that I started receiving the following error after upgrading from Flask-Ask 0.9.6.

  File "/var/task/flask_ask/core.py", line 6, in <module>
  from StringIO import StringIO
ModuleNotFoundError: No module named 'StringIO'

@mlsamuelson
Copy link
Contributor Author

Looks like there's already two similar pull requests for this issue. Apologies for the extra noise.

@samalba
Copy link

samalba commented Feb 19, 2018

+1 for merging, master is broken with python3...

@johnwheeler johnwheeler merged commit 564a342 into johnwheeler:master Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants