Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with slight nuance between io packages in PY2 and PY3. #234

Merged
merged 2 commits into from
Jun 27, 2018

Conversation

fergyfresh
Copy link
Contributor

@fergyfresh fergyfresh commented May 30, 2018

While using AWS Lambda directly the change to BytesIO works fine for python2, but fails in python3. I am currently using this fork for using PY3 with Lambda. In python3 BytesIO is expecting a byte-like type and in python2 it can take a string. This fixes it for my use-case and leaves the current setup unchanged.

@fergyfresh
Copy link
Contributor Author

@m0ngr31 this is the fix to the issue I e-mailed you about.

@m0ngr31 m0ngr31 merged commit 29f16f1 into johnwheeler:master Jun 27, 2018
@m0ngr31
Copy link
Collaborator

m0ngr31 commented Jun 27, 2018

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants