-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds sbt-typelevel #4
Conversation
320a61e
to
d2106c2
Compare
@johnynek if you could take a look and let me know what to do about these AWS failures. Maybe just ignoring these tests for now? Also, should we be working on this branch or master? |
oh weird... somehow this branch got set as the default. We should change that. So you can comment out the test, but the bigger question is why are we hitting any AWS initialization code? There is probably something impure going on that is breaking things that will bite us elsewhere. It may be as easy as finding something and making the initialization Lastly, cats-effect got much better in cats-effect 3 (fixing the need for |
but to be clear: just comment out anything you need to get this green, then we will deal with the better fix later. |
I've set the default branch to master, but let's keep this pr against this weird one, and then just force push the weird one to master. |
Perfect, will pick this up later today. I would like this repo to work with 2.11 so we can use this at work without trouble but we would have to leave so much behind... What a pain :/ |
Ah BTW, what license should be used? I set it to Apache to try it out. |
Basically in S3App we just need to make these lazy:
|
a0b9af6
to
df4e4cc
Compare
Not sure what Mergify is about, let me know what else needs to be done in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, but big diff...
mergify can automatically merge some changes (e.g. those from scala-steward that are green). |
Added sbt-typelevel, mostly following the instructions on the site, trying to stick to the defaults and typelevel/paiges#449.
NoPublishPlugin
to all modules so there is no publishing yet