Thread group label #123
Merged
Thread group label #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prometheus Listener now supports value 'threadGroup' in the Labels column. Updated some dependencies.
|
Hi, terribly sorry for the delay, and thank you so much for the contribution! I'm going to merge this now then leave comments for myself for a few things to change. Instead of waiting for you after so long, I'll just take care of it. Thanks again for the PR! |
johrstrom
reviewed
Jul 29, 2023
Comment on lines
+87
to
+96
| <dependency> | ||
| <groupId>org.apache.commons</groupId> | ||
| <artifactId>commons-lang3</artifactId> | ||
| <version>3.12.0</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.slf4j</groupId> | ||
| <artifactId>slf4j-api</artifactId> | ||
| <version>2.0.7</version> | ||
| </dependency> |
There was a problem hiding this comment.
I don't think we need these - or if we do they're in provided scope.
johrstrom
reviewed
Jul 29, 2023
| <dependency> | ||
| <groupId>org.apache.jmeter</groupId> | ||
| <artifactId>ApacheJMeter_components</artifactId> | ||
| <version>${jmeter.version}</version> |
There was a problem hiding this comment.
Should have provided scope because we use the shade plugin to build a uber jar with the dependencies in it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prometheus Listener now supports value 'threadGroup' in the Labels column.
Updated some dependencies.
Fixes #66