Update to support Rails 7.0 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davkutalek
changed the title
timlkelly
reviewed
Aug 14, 2024
There was a problem hiding this comment.
Initial comments and testing. I set my local knockoff to this branch and then set ENABLE_REPLICAS=true in my .env.development.local and received this error:
F, [2024-08-14T15:26:35.931451 #85048] FATAL -- : [d32d9ef4-91fd-43be-914a-db4209c31fc7] [Chrome 127.0.0.0] [::1] [dd.env=development dd.service=handshake dd.trace_id=3860344763007303586 dd.span_id=0 ddsource=ruby]
[d32d9ef4-91fd-43be-914a-db4209c31fc7] [Chrome 127.0.0.0] [::1] [dd.env=development dd.service=handshake dd.trace_id=3860344763007303586 dd.span_id=0 ddsource=ruby] NameError (uninitialized constant Knockoff::ActiveRecord::Base
open_transactions = run_on(:primary) { ActiveRecord::Base.connection.open_transactions }
^^^^^^
Did you mean? Base64):
[d32d9ef4-91fd-43be-914a-db4209c31fc7] [Chrome 127.0.0.0] [::1] [dd.env=development dd.service=handshake dd.trace_id=3860344763007303586 dd.span_id=0 ddsource=ruby]
[d32d9ef4-91fd-43be-914a-db4209c31fc7] [Chrome 127.0.0.0] [::1] [dd.env=development dd.service=handshake dd.trace_id=3860344763007303586 dd.span_id=0 ddsource=ruby] lib/middleware/next/transition_redirections.rb:25:in `call'
davkutalek
commented
Aug 14, 2024
added 2 commits
August 14, 2024 15:23
… as path in host gemfile
timlkelly
reviewed
Aug 15, 2024
README.md
Outdated
| @@ -17,7 +17,29 @@ A gem for easily using read replicas. | |||
|
|
|||
| ## Supported Versions | |||
|
|
|||
| Knockoff supports Rails 4, 5 and 6 | |||
| | Knockoff version: | 1.0 | 1.1.0 | 1.1.1 | 1.4 | 1.5 | | |||
| | -------- | ------- | -------- | ------- | -------- | | |||
There was a problem hiding this comment.
I think you need one more divider. There are six columns in total. Right now, it looks like this
timlkelly
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with existing 6.1 application and a 7.0 app.
Once this is merged I'll create a release and push it to ruby gems.