Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test against Django 1.11 #108

Merged
merged 3 commits into from
Apr 11, 2017
Merged

Test against Django 1.11 #108

merged 3 commits into from
Apr 11, 2017

Conversation

edmorley
Copy link

@edmorley edmorley commented Jan 20, 2017 •
edited
Loading

The >=1.11a1,<2.0 specifier will avoid having to adjust the version as the Django 1.11 pre-release cycle continues.

Also stops testing Django master against Python 2, since they dropped support for it.

@coveralls
Copy link

coveralls commented Jan 20, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 88.312% when pulling 73a7d5f on edmorley:django1.11 into 43d572f on joke2k:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.312% when pulling 73a7d5f on edmorley:django1.11 into 43d572f on joke2k:develop.

@coveralls
Copy link

coveralls commented Jan 20, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 88.312% when pulling e27c5da on edmorley:django1.11 into 43d572f on joke2k:develop.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.312% when pulling e27c5da on edmorley:django1.11 into 43d572f on joke2k:develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.312% when pulling e27c5da on edmorley:django1.11 into 43d572f on joke2k:develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.312% when pulling e27c5da on edmorley:django1.11 into 43d572f on joke2k:develop.

@coveralls
Copy link

coveralls commented Jan 20, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 88.312% when pulling 4a09a8f on edmorley:django1.11 into 43d572f on joke2k:develop.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.312% when pulling 4a09a8f on edmorley:django1.11 into 43d572f on joke2k:develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.312% when pulling 4a09a8f on edmorley:django1.11 into 43d572f on joke2k:develop.

auvipy
auvipy approved these changes Apr 6, 2017
View reviewed changes
Copy link

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job

.travis.yml Outdated
@@ -11,11 +11,12 @@ env:
- DJANGO="Django>=1.8,<1.9"
- DJANGO="Django>=1.9,<1.10"
- DJANGO="Django>=1.10,<1.11"
- DJANGO="Django>=1.11a1,<2.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.11 is proper now

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

Ed Morley added 2 commits April 10, 2017 10:28
Test against Django 1.11
a6b97a1 
The `>=1.11a1,<2.0` specifier will avoid having to adjust the version
as the Django 1.11 pre-release cycle continues.
Stop testing Django master against Python 2
b072900 
Since it has dropped support for it.
@edmorley
Copy link
Author

@joke2k please could you merge this?

@edmorley edmorley mentioned this pull request Apr 10, 2017
Closed
@coveralls
Copy link

coveralls commented Apr 10, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 88.312% when pulling b072900 on edmorley:django1.11 into 43d572f on joke2k:develop.

@Surgo
Copy link
Contributor

Surgo commented Apr 11, 2017

👍

@joke2k
Copy link
Owner

joke2k commented Apr 11, 2017

Absolutely!
I'll release a new version tomorrow

@joke2k joke2k merged commit e92fddd into joke2k:develop Apr 11, 2017
@edmorley edmorley deleted the django1.11 branch April 14, 2017 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auvipy auvipy auvipy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@edmorley @coveralls @Surgo @joke2k @auvipy