Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing tests in various address providers #1352

Closed
13 tasks
JoseNavy opened this issue Dec 28, 2020 · 1 comment
Closed
13 tasks

Missing tests in various address providers #1352

JoseNavy opened this issue Dec 28, 2020 · 1 comment

Comments

@JoseNavy
Copy link
Contributor

  • Faker version: 5.0.2
  • OS: Mac OS Big Sur

While creating another provider for a PR and doing it's necessary tests, I noticed that there are some address providers that don't have tests. I think that every provider should have it's test for uniformity and assurance that the provider works, but I don't know if they are really necessary. The list of address providers without tests are:

  • en_NZ
  • fil_PH
  • fr_CH
  • hu_HU
  • id_ID
  • it_IT
  • ka_GE
  • ko_KR
  • sk_SK
  • si_SI
  • sv_SE
  • tl_PH
  • uk_UA

Should this tests be added?

@fcurella
Copy link
Collaborator

Thank you for looking into thism @JoseNavy !

Yes, we should have tests for those providers. A Pull Request would be very much appreciated :)

fcurella pushed a commit to epetrovski/faker that referenced this issue Mar 7, 2022
…1616)

* Adding more tests to address providers

* Fixing two small code mistakes which caused failure

* Reformation by black and deleting double tests

* Running make lint for formatting

* Deleting unused imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants