Return list instead of tuple in choices_distribution #1485
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this changes
This is a proposed fix for #1484.
It appears this line has come up in the past: #1367 (comment) and #1368 (review).
What was wrong
We should not return a tuple here as that type is not the same as what
random.choices
(below it) would return (assuming the default implementation in the standard library). Theelse
part below it also uses achoices
list to return at the end.How this fixes it
This adds a test case for
random_letters
in general and it specifically asserts that the return value is alist
, as mentioned in the docstring ofrandom_letters()
.