Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed it_IT ssn() validity #1612

Merged
merged 2 commits into from
Feb 10, 2022
Merged

Fixed it_IT ssn() validity #1612

merged 2 commits into from
Feb 10, 2022

Conversation

MarcoMatarazzo
Copy link
Contributor

What does this changes

Fixed It_IT ssn() (codice fiscale) validity.

What was wrong

It_IT ssn() (codice fiscale) does not produce correct strings, according to the official algorythm.

How this fixes it

Better generation, fixes:

  • Letter corresponding to Month (one of A, B, C, D, E, H, L, M, P, R, S, T)
  • Numbers corresponding to Day of the Month (between 00-31 for males or 40-71 for females)
  • Letters and Numbers corresponding to Municipality (offical, long list)

@MarcoMatarazzo MarcoMatarazzo mentioned this pull request Feb 9, 2022
Closed
fcurella
fcurella requested changes Feb 9, 2022
View reviewed changes
Copy link
Collaborator

@fcurella fcurella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! could you run make lint to format the code?

@MarcoMatarazzo
Copy link
Contributor Author

Thank you! could you run make lint to format the code?

Done.

@fcurella
Copy link
Collaborator

Thank you!

@fcurella fcurella merged commit 67a3442 into joke2k:master Feb 10, 2022
fcurella pushed a commit to epetrovski/faker that referenced this pull request Mar 7, 2022
@MarcoMatarazzo @fcurella
Fixed it_IT ssn() validity (joke2k#1612)
c7fb9a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcurella fcurella fcurella approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcoMatarazzo @fcurella