Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace archived faker-optional with my alternative #1749

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Replace archived faker-optional with my alternative #1749

merged 1 commit into from
Nov 14, 2022

Conversation

PerchunPak
Copy link
Contributor

@PerchunPak PerchunPak commented Nov 13, 2022

faker-optional was archived 9 months ago. I recently created an alternative to replace it.

@stefan6419846
Copy link
Contributor

Just from a general development perspective: Does it really make sense to create a completely new repository without the old commit history and publish a new package under a different name when the original repository explicitly states:

No longer maintained: I use pydantic-factories instead, if you want to maintain this repo, I can transfer it to you.

@PerchunPak
Copy link
Contributor Author

I wrote the author, and he didn't answer for ~3 days. I also didn't take anything from the original repo, and wrote everything from zero.

If you look at old implementation, and mine, you will see that they are completely different.

@PerchunPak PerchunPak changed the title Replace archived faker-optional with my fork Replace archived faker-optional with my alternative Nov 13, 2022
@stefan6419846
Copy link
Contributor

Thanks for the explanations - I did not have a closer look at the actual code and you were speaking of a fork as well.

Copy link
Collaborator

@fcurella fcurella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fcurella fcurella merged commit d01a1b9 into joke2k:master Nov 14, 2022
@PerchunPak PerchunPak deleted the patch-2 branch November 14, 2022 16:22
@lyz-code
Copy link
Contributor

I'm the author of the old code and I'm fine with the change. If I were quicker answering maybe I could have transferred the repo.

I take the chance to thank you all again for maintaining faker :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants