Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add decorator to optionally format dates as string #2099

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Add decorator to optionally format dates as string #2099

merged 2 commits into from
Oct 7, 2024

Conversation

browniebroke
Copy link
Contributor

@browniebroke browniebroke commented Sep 4, 2024 •
edited
Loading

What does this change

Update date time provider to allow formatting all dates as string by passing a pattern keyword arguments.

Fix #2097

@browniebroke browniebroke force-pushed the date-as-strings-decorator branch from c47f70f to 4d881ac Compare September 4, 2024 09:43
@browniebroke browniebroke marked this pull request as draft September 4, 2024 10:25
This was referenced Sep 4, 2024
Closed
Closed
@browniebroke browniebroke marked this pull request as ready for review September 4, 2024 16:54
fcurella
fcurella requested changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@fcurella fcurella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proxy.pyi is auto-generated by generate_stubs.py, and shouldn't be edited manually. Can you undo the changes to the file?

@browniebroke
Copy link
Contributor Author

Ah right. Will do

@browniebroke browniebroke force-pushed the date-as-strings-decorator branch from c2f71d1 to 3a866f6 Compare September 19, 2024 20:36
@browniebroke
Copy link
Contributor Author

proxy.pyi is auto-generated by generate_stubs.py, and shouldn't be edited manually. Can you undo the changes to the file?

Done

fcurella
fcurella approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@fcurella fcurella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fcurella fcurella merged commit dd1e446 into joke2k:master Oct 7, 2024
56 checks passed
@browniebroke browniebroke deleted the date-as-strings-decorator branch October 7, 2024 16:47
fcurella added a commit that referenced this pull request Oct 31, 2024
@fcurella
Revert "Add decorator to optionally format dates as string (#2099)"
72e92dd 
This reverts commit dd1e446.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcurella fcurella fcurella approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optionally return dates as strings in datetime provider
2 participants
@browniebroke @fcurella