Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't assume that profiles for index.php are from webgrind itself #147

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't assume that profiles for index.php are from webgrind itself #147

wants to merge 1 commit into from

Conversation

kasparsd
Copy link

Fixes #130.

  • Webgrind is a generic tool to display Xdebug profiling results. It works by parsing all /tmp/cachegrind.out* files.
  • It currently assumes that all profiling results for index.php are from Webgrind itself. That is a generic assumption and doesn't apply in any of the Docker use-cases where the Webgrind container is attached to the /tmp directory of other PHP containers.

Solutions:

  • Default to showing all profiling results.
  • Alternative: offer an environment variable or some other configuration option to adjust this particular behaviour.

@kasparsd kasparsd mentioned this pull request Sep 21, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker Webgrind ignores index.php by default and is not configurable.
1 participant
@kasparsd