fix(CI): fixed TerminalNotifierDriver tests

jolicode · Oct 4, 2024 · b88fc98 · b88fc98
1 parent b47ce70
commit b88fc98
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ## Not released yet
 
+* Added support for sound option on TerminalNotifier notifier
+
 ## 3.0.0 (2024-10-02)
 
 * Remove deprecated code:

diff --git a/README.md b/README.md
@@ -45,7 +45,7 @@ $notification =
     ->setBody('This is the body of your notification')
     ->setIcon(__DIR__.'/path/to/your/icon.png')
     ->addOption('subtitle', 'This is a subtitle') // Only works on macOS (AppleScriptDriver)
-    ->addOption('sound', 'Frog') // Only works on macOS (AppleScriptDriver)
+    ->addOption('sound', 'Frog') // Only works on macOS (AppleScriptDriver & TerminalNotifierDriver)
 ;
 
 // Send it

diff --git a/tests/Driver/TerminalNotifierDriverTest.php b/tests/Driver/TerminalNotifierDriverTest.php
@@ -94,7 +94,7 @@ protected function getExpectedCommandLineForNotificationWithAllOptions(): string
         }
 
         return <<<'CLI'
-            'terminal-notifier' '-message' 'I'\''m the notification body' '-title' 'I'\''m the notification title' '-open' 'https://google.com' '-sound' 'Frog' 
+            'terminal-notifier' '-message' 'I'\''m the notification body' '-title' 'I'\''m the notification title' '-open' 'https://google.com' '-sound' 'Frog'
             CLI;
     }
 }