add -contentImage option to TerminalNotifier

[vesper8]

Related to #73

Since appIcon is no longer supported, there is this alternative to including an image using -contentImage and this PR adds the ability to set the appImage as an option.

[pyrech]

Thanks for you PR 🤗

Could you add a note in the CHANGELOG and a test?

[pyrech]

Do you have some link explaining why appIcon is no longer supported on TerminalNotifier? If this is a dead option, should we now pass it to the keep -contentImage option directly (without adding a new contentImage in the notification)?

[vesper8]

Only link I have is the issue I linked in the post above where you yourself suggested The only thing here we can do here is to change a bit the behaviour of terminal-notifier to embed an image instead of trying to change the notification's icon by using -contentImage instead of -appIcon

I tried your solution and contentImage does indeed allow us to pass an image or icon, and the appIcon appears to do nothing at all. So yes I guess it does look like it's a dead option now.

[pyrech]

Hi @vesper8 I changed a bit your PR to make use of terminal-notifier's contentImage option instead of appIcon, so no need to support a new option for users. Thanks for your initial work on this PR 🙂

[vesper8]

@pyrech Thank you : )

New tagged release on the way? <3

[pyrech]

I will tag a new version in a few days, I would like to merge some PRs before ;)