Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): try to get types from read accessor / write mutator first #77

Merged
merged 4 commits into from
Mar 20, 2024
Merged

fix(types): try to get types from read accessor / write mutator first #77

merged 4 commits into from
Mar 20, 2024

Conversation

joelwurtz
Copy link
Member

Partially fix #5

Korbeil
Korbeil reviewed Mar 20, 2024
View reviewed changes
Copy link
Member

@Korbeil Korbeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a comment about all the code that should be within Symfony later on ?
Cause it's a lot of code duplication (and it's indeed to fix our issue), but this code shouldn't be on our side in the end.

@joelwurtz joelwurtz merged commit 44b3c49 into 9.0 Mar 20, 2024
12 checks passed
@joelwurtz joelwurtz deleted the fix/get-types-from-accessor-mutator branch March 20, 2024 15:22
@joelwurtz joelwurtz mentioned this pull request Mar 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Korbeil Korbeil Korbeil left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joelwurtz @Korbeil