Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#512): repack command work without .castor folder #513

Merged
merged 1 commit into from
Sep 3, 2024
Merged

fix(#512): repack command work without .castor folder #513

merged 1 commit into from
Sep 3, 2024

Conversation

arnolem
Copy link
Contributor

@arnolem arnolem commented Aug 31, 2024

@lyrixx
Copy link
Member

lyrixx commented Sep 3, 2024

Hello @arnolem ; Thanks for the PR.

Could you look at failing test? Thanks

@lyrixx
Copy link
Member

lyrixx commented Sep 3, 2024

hmm, nevermind, it looks like we have some failures on main branch

lyrixx
lyrixx approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have rebased your PR.

Thanks for the fix 👏🏼

pyrech
pyrech approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@pyrech pyrech left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. It deserves a note in the changelog IMO

@lyrixx
Copy link
Member

lyrixx commented Sep 3, 2024 •
edited by pyrech
Loading

Thanks for the fix. It deserves a note in the changelog IMO

I did it 👍🏼

Thanks again @arnolem

@lyrixx lyrixx merged commit 2fd7484 into jolicode:main Sep 3, 2024
9 checks passed
@lyrixx lyrixx mentioned this pull request Sep 3, 2024
Closed
@arnolem
Copy link
Contributor Author

arnolem commented Sep 3, 2024

Thanks for the fix. It deserves a note in the changelog IMO

Okay, I'll know for next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyrixx lyrixx lyrixx approved these changes

@pyrech pyrech pyrech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arnolem @lyrixx @pyrech