Upgrade NodeJS to version 16.x LTS and remove deprecated apt-key usage #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyrixx
reviewed
Mar 3, 2022
| RUN echo "deb https://deb.nodesource.com/node_${NODEJS_VERSION} bullseye main" > /etc/apt/sources.list.d/nodejs.list \ | ||
| && apt-key adv --fetch-keys https://deb.nodesource.com/gpgkey/nodesource.gpg.key | ||
| ARG NODEJS_VERSION=16.x | ||
| RUN curl -s https://deb.nodesource.com/gpgkey/nodesource.gpg.key | gpg --dearmor | tee /usr/share/keyrings/nodesource.gpg >/dev/null \ |
There was a problem hiding this comment.
I think this could be simpler :
curl -s https://deb.nodesource.com/gpgkey/nodesource.gpg.key| gpg --dearmor > /usr/share/keyrings/nodesource.gpg
I have another question, why did you change the way the package signature is checked?
There was a problem hiding this comment.
I will simplify the command, good catch (I followed the way its done by NodeJS scripts)
apt-key will be removed in future distributions versions (see Debian wiki or this article)
There was a problem hiding this comment.
Oh, thanks for this Information. I didn't know.
There was a problem hiding this comment.
Simplified commands 🙂
Switch to current LTS version of NodeJS and use keyrings files directly instead of now deprecated apt-key usage
kissifrot
force-pushed
the
upgrade-nodejs-change-keyrings
branch
from
d068893 to
6c7e77c
Compare
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to current LTS version of NodeJS and use keyrings files directly instead of now deprecated apt-key usage