Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the npm/yarn install for mac users #183

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

qboot
Copy link
Member

@qboot qboot commented Jun 15, 2022

Most of our mac users don't use anymore Dinghy but have still some troubles with running yarn / webpack on the Docker stack.

This change allow every mac users to execute npm/yarn commands on their host instead of within docker, regardless of if they are using Dinghy or Docker Desktop.

@lyrixx
Copy link
Member

lyrixx commented Jun 15, 2022

If we go this way, let's remove the dinghy notion an remplace it with macos, or at least add a global configuration variable macos thats is equals to dinghy or macos ? WDYT?

And about the feature : I don't have any inputs, I don't use mac OS.

Last note: please add an entry in the CHANGELOG.md, thanks

@qboot qboot force-pushed the fix/run-in-docker-locally-for-mac branch from 2c2bc23 to 7fab0af Compare June 15, 2022 13:37
@qboot qboot force-pushed the fix/run-in-docker-locally-for-mac branch from 7fab0af to 56e64ef Compare June 15, 2022 13:43
@qboot
Copy link
Member Author

qboot commented Jun 15, 2022

I'm not a big fan of removing the dinghy notion yet, it would be a breaking change for the users still using it.
And there is still specific code here: https://github.com/jolicode/docker-starter/blob/main/tasks.py#L44-L48

@qboot qboot requested a review from lyrixx June 15, 2022 13:44
Copy link
Member

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect thanks

@lyrixx lyrixx merged commit 0b4f180 into main Jun 15, 2022
@lyrixx lyrixx deleted the fix/run-in-docker-locally-for-mac branch June 15, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants