Seed phrase recovery #304
Merged
Seed phrase recovery #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VolkerSchiewe
force-pushed
the
300/seed-phrase-recovery
branch
from
2c8d450 to
14c7cef
Compare
chunningham
reviewed
Apr 29, 2019
There was a problem hiding this comment.
should the recoverIdentity function also return an IdentityWallet? the returned vkp could be used to construct one and then the function wouldnt depend on a registry and wouldnt need to be async. In that case it would basically be a constructor for a vkp. I think we discussed this before but I dont quite remember the conclusion we came to
|
@chunningham I moved the recovery method to be part of the vkp and works basically like a constructor for it. |
chunningham
approved these changes
May 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it is a good idea to move every thing that is mnemonic related to the lib, but I'm not sure if adding the
getMnemonicmethod to the key provider is a good idea as it is kind of similar to thegetPrivateKey-antipattern, isn't it?cloeses #300