Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DID Document implementation #310

Merged
merged 11 commits into from
Aug 28, 2019
Merged

Update DID Document implementation #310

merged 11 commits into from
Aug 28, 2019

Conversation

VolkerSchiewe
Copy link
Contributor

No description provided.

@VolkerSchiewe VolkerSchiewe self-assigned this May 23, 2019
@mnzaki
Copy link
Contributor

mnzaki commented May 23, 2019 •
edited
Loading

We might still want to use AuthenticationSection I think, in some cases we might want to inline the publicKey instead of just refer to it, and also to support reading DDOs with them. At least in the case of migration, we would want to keep support for the older style

@mnzaki
Copy link
Contributor

mnzaki commented May 24, 2019 •
edited
Loading

I'm basing the DDO migration/versioning work on this branch

@mnzaki mnzaki force-pushed the 308/did-document-update branch from fc52a34 to 32a31fb Compare May 28, 2019 13:46
@mnzaki mnzaki requested review from Exulansis and chunningham May 28, 2019 15:11
Exulansis
Exulansis requested changes Jun 26, 2019
View reviewed changes
Copy link
Collaborator

@Exulansis Exulansis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ends up in invalid signatures on the updated DID documents, we will have to make sure we update the signature before committing the did document.

@VolkerSchiewe VolkerSchiewe requested review from Exulansis and mnzaki July 2, 2019 08:27
@VolkerSchiewe VolkerSchiewe force-pushed the 308/did-document-update branch from 011048a to 1636541 Compare July 31, 2019 14:13
@VolkerSchiewe VolkerSchiewe mentioned this pull request Aug 2, 2019
Closed
@Exulansis Exulansis force-pushed the 308/did-document-update branch from 8a978cf to 1584f1b Compare August 11, 2019 15:20
@Exulansis
Copy link
Collaborator

#340 Addresses most of the comments raised here.

@chunningham chunningham merged commit 6a0f900 into develop Aug 28, 2019
@chunningham chunningham mentioned this pull request Aug 28, 2019
Closed
@Exulansis Exulansis mentioned this pull request Sep 19, 2019
Open
@Exulansis Exulansis deleted the 308/did-document-update branch May 28, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunningham chunningham chunningham approved these changes

@Exulansis Exulansis Exulansis approved these changes

@mnzaki mnzaki Awaiting requested review from mnzaki

Assignees

@VolkerSchiewe VolkerSchiewe

Labels
breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VolkerSchiewe @mnzaki @Exulansis @chunningham