Updated encrypt / decrypt implementations to use IVs #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the SoftwareKeyProvider class and it's associated tests.
|
|
||
| **Instantiate the Key Provider class** | ||
|
|
||
| The ``SoftwareKeyProvider`` class abstracts all functionality related to `deriving key pairs <https://github.com/bitcoin/bips/blob/master/bip-0032.mediawiki>`_ and creating / validating cryptographic signatures. | ||
| The 32 byte seed used to instantiate the key provider is persisted in the instance, encrypted using the provided password. Therefore, all operations which involve key derivation require the password as well. | ||
| This is what instantiating a key provider looks like: | ||
| Currently two ways of instantiating the class are supported, namely using the constructor or using the static ``fromSeed`` method: |
There was a problem hiding this comment.
Just as a side note: also recover key pair creates a new softwareKeyProvider and takes the mnemonic as argument. But it's probably more confusing than helpful at this point.
VolkerSchiewe
approved these changes
Jul 31, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the SoftwareKeyProvider class and it's associated tests.
Implements #322